Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --skip works for --all-features #48

Closed
taiki-e opened this issue Jun 21, 2020 · 1 comment
Closed

Make --skip works for --all-features #48

taiki-e opened this issue Jun 21, 2020 · 1 comment
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.)

Comments

@taiki-e
Copy link
Owner

taiki-e commented Jun 21, 2020

#47 (comment)

Making --skip works for --all-features is probably one of the reasonable solutions for this. If one feature is non-additive and other features are additive (e.g., using different implementations between std and no-std), I think this is enough.
@taiki-e taiki-e added the C-enhancement Category: A new feature or an improvement for an existing one label Jun 21, 2020
@taiki-e taiki-e mentioned this issue Jul 11, 2020
Closed
@taiki-e taiki-e added A-features Area: features (--feature-powerset, --each-feature, etc.) and removed C-enhancement Category: A new feature or an improvement for an existing one labels Oct 10, 2020
@taiki-e
Copy link
Owner Author

taiki-e commented Oct 16, 2020

IIRC --all-features is special. Instead of this, I prefer to accept #42 and to add --skip-all-features like --skip-no-default-features.

cargo-hack/tests/long-help.txt

Lines 49 to 52 in 45cafc0

--skip-no-default-features
Skip run of just --no-default-features flag.
This flag can only be used with either --each-feature flag or --feature-powerset flag.

@taiki-e taiki-e closed this as completed Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taiki-e