Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶 - TuiMultiSelectModule does not export TuiTextfieldDirective #7461

Open
2 of 9 tasks
hakimio opened this issue May 17, 2024 · 4 comments
Open
2 of 9 tasks

馃悶 - TuiMultiSelectModule does not export TuiTextfieldDirective #7461

hakimio opened this issue May 17, 2024 · 4 comments
Labels
bug Something isn't working state: need triage

Comments

@hakimio
Copy link
Contributor

hakimio commented May 17, 2024

Playground Link

No response

Description

Unlike all the rest of Taiga input modules, TuiMultiSelectModule does not export TuiTextfieldDirective.
So, if you are using ComboBox, you can do the following:

<tui-combo-box
    [formControl]="myControl"
>
    My Label
    <input
        autocomplete="new-password"
        tuiTextfield
    />
</tui-combo-box>

But the following will give you an error:

<tui-multi-select
    [formControl]="myControl"
>
    My Label
    <input
        autocomplete="new-password"
        tuiTextfield
    />
</tui-multi-select>

Angular version

17.3.8

Taiga UI version

3.77.1

Which browsers have you used?

  • Chrome
  • Firefox
  • Safari
  • Edge

Which operating systems have you used?

  • macOS
  • Windows
  • Linux
  • iOS
  • Android
@hakimio hakimio added bug Something isn't working state: need triage labels May 17, 2024
@waterplea
Copy link
Collaborator

Thanks for pointing it out. Would you be willing to make a PR into the v3 branch?

@hakimio
Copy link
Contributor Author

hakimio commented May 17, 2024

I am quite busy right now, but might be able to take a look at this at the end of next week. If someone wants to take this before that, feel free to go ahead.

@hakimio
Copy link
Contributor Author

hakimio commented May 28, 2024

Quickly took a look at this and it seems to me that for multi-select to accept input[tuiTextfield], input-tag template needs some major changes which include replacing simple input with primitive-textfield.
If someone wants to take this, feel free to do it.

@waterplea
Copy link
Collaborator

Oh, right, it just doesn't support that at all, sorry. Seems like this will have to wait for 4.0 when all textfields will be reworked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working state: need triage
Development

No branches or pull requests

2 participants