Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a.list-group-item-actions do not behave correct with icon fonts #1836

Open
nerdoc opened this issue Feb 28, 2024 · 1 comment
Open

a.list-group-item-actions do not behave correct with icon fonts #1836

nerdoc opened this issue Feb 28, 2024 · 1 comment

Comments

@nerdoc
Copy link

nerdoc commented Feb 28, 2024

I think there are three issues with the list-group-item-actions.

  1. if you have more than one icons, even svgs like in your preview, the link underline is visisble a bit, beween the icons:
    grafik

you can test that on https://tabler.io/preview, right side, you have the actions in the list items, just open the browser's inspector and copy/paste another a.list-group-item-actions.

  1. Another thing is that you are using svg icons in your preview. I don't want to use svg icons, but webfonts, as I use Django with no Js frontend. This looks terrible, as the underline is drawn here in full beauty:

grafik

I am using this code here: <i class="ti ti-{{ icon }} fs-2"></i>

I think in css there is missing something like a

a.list-group-item-actions:hover {
  text-decoration:none;
}
  1. BTW - is the name "list-group-item-actions" a good one? wouldn't that sound better as list-group-item-action - because it is one, the plural form I would suspect to be as a class of a parent div. But changing this would be backwards incompatible - BUT: you are not 1.0.0 yet. it's beta20.
nerdoc added a commit to nerdocs/conjunto that referenced this issue Feb 28, 2024
@nerdoc
Copy link
Author

nerdoc commented May 11, 2024

There may be a related problem - the same behaviour is seen in input-group.input-group-flat > input-group-text > a.link-secondary > svg /i.ti.ti-x
Your example in the preview, Form elements shows this with a svg icon:
grafik

When copied and with the X icon replaced by <i class="ti ti-x"></i>, it looks like this:
grafik

Again, mind the "link" style underline below the X - this is seen with all "icon" style fonts when used within buttons IMHO, be it action buttons or a.link-secondary

a.list-group-item-actions:hover,
.input-group-text  a:hover {
  text-decoration:none;
}

This is definitely not a solution, just a small workaround. But This should be fixed IMHO, as it renders icon fonts for some links in an ugly way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant