Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] $font-family-monospace not declared as default #1812

Open
jeremystretch opened this issue Jan 8, 2024 · 0 comments
Open

[BUG] $font-family-monospace not declared as default #1812

jeremystretch opened this issue Jan 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jeremystretch
Copy link

Browser

Firefox 114

OS

Linux

Screen size

2560x1440

Describe the bug

Disclaimer: I'm not much of a frontend dev, so apologies if I've missed something obvious.

It seems that !default has been omitted from the declaration of $font-family-monospace in _variables.scss:

/* prettier-ignore */
$font-family-sans-serif: unquote("#{if($font-local, "#{$font-local}, ", ' ')}#{if($font-google, "#{$font-google}, ", ' ')}") -apple-system, BlinkMacSystemFont, San Francisco, Segoe UI, Roboto, Helvetica Neue, sans-serif !default;
/* prettier-ignore */
$font-family-monospace: unquote("#{if($font-google-monospaced, "#{$font-google-monospaced}, ", '')}") Menlo, Monaco, Consolas, Liberation Mono, Courier New, monospace;

My understanding is that the initial value provided here should be marked as a default, as $font-family-sans-serif above it is (as well as practically every other variable in the file).

How to reproduce

  1. Define your own values for $font-family-sans-serif and $font-family-monospace prior to loading Tabler variables.
  2. Compile CSS
  3. Notice that the custom value for $font-family-sans-serif is retained but the value of $font-family-monospace is overwritten.

Screenshots

No response

JSFiddle

No response

@jeremystretch jeremystretch added the bug Something isn't working label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant