Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add vscode installer #1869

Closed
wants to merge 8 commits into from
Closed

feat: add vscode installer #1869

wants to merge 8 commits into from
+43 −0

Conversation

thecmdrunner
Copy link
Contributor

@thecmdrunner thecmdrunner commented May 4, 2024 •
edited

Closes #1852

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

  1. Add a installer for vscode, along with some handy settings for Next.js:
    • Use custom editor labels for pages, layouts and API routes.
    • Uses the project-specific typescript version by default, so it can use the TypeScript Plugin for Next.js

Screenshots

Before

image

After

image

💯

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 4, 2024 •
edited

🦋 Changeset detected

Latest commit: ff130cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented May 4, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2024 6:44pm

@vercel Vercel
Copy link

vercel bot commented May 4, 2024

@thecmdrunner is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@thecmdrunner thecmdrunner changed the title Feat/vscode-installer feat: add vscode installer May 4, 2024
@thecmdrunner thecmdrunner marked this pull request as draft May 4, 2024 19:54
@thecmdrunner thecmdrunner marked this pull request as ready for review May 5, 2024 18:46
@thecmdrunner thecmdrunner marked this pull request as draft May 5, 2024 18:47
@thecmdrunner
Copy link
Contributor Author

thecmdrunner commented May 5, 2024 •
edited

Some tests are failing probably because they didn't pull the updated code 🤔
Other similar tests do pass though. Also works locally

@thecmdrunner thecmdrunner marked this pull request as ready for review May 5, 2024 18:53
@juliusmarminge
Copy link
Member

Hey thanks for your PR, but we have previously been reluctant to add editor-specific configurations to create-t3-app.

While I do like the change, not everyone uses vscode and forcing configs on them shouldn't be our job.

@thecmdrunner
Copy link
Contributor Author

Got it, no issues :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge Awaiting requested review from juliusmarminge juliusmarminge is a code owner

@nexxeln nexxeln Awaiting requested review from nexxeln nexxeln is a code owner

@t3dotgg t3dotgg Awaiting requested review from t3dotgg t3dotgg is a code owner

@c-ehrlich c-ehrlich Awaiting requested review from c-ehrlich c-ehrlich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: custom editor labels for nextjs file conventions
2 participants
@thecmdrunner @juliusmarminge