Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced options -s and -m not working? #19

Open
ghost opened this issue Sep 4, 2013 · 3 comments
Open

Advanced options -s and -m not working? #19

ghost opened this issue Sep 4, 2013 · 3 comments
Assignees

Comments

@ghost
Copy link

ghost commented Sep 4, 2013

I guess I've used this options in a previous version of lz4mt, but with the current one they do not work. There is no parsing of the options in the code.

Were they removed (are they coming back?) or am I missing something really basic?
Would be great to have them as also a "max thread number" option :)

@t-mat
Copy link
Owner

t-mat commented Sep 5, 2013

Hi samuel.

Yes, you are right. -s and -m are removed. There is a command-line option incompatibility since a00ed22. I'm sorry for inconvenience.

And your "max thread number" option sounds good 👍
Since I've decided lz4mt should be maximum compatible with lz4c. New lz4mts exclusive option will look like following:

option means
--lz4mt-thread 0 Compatible -m. Use all available threads.
--lz4mt-thread 1 Compatible -s. Use single thread.
--lz4mt-thread N Use N threads.(Future plan. Depends on thread pool implementation)

I'll add new issue to implement this new option later.

@ghost
Copy link
Author

ghost commented Sep 9, 2013

Ah that's great! I'm glad that the options will be back 👍 Do you have an estimate for when?

t-mat added a commit that referenced this issue Sep 9, 2013
Add new option --lz4mt-thread.
Fix command-line help text.
@t-mat
Copy link
Owner

t-mat commented Sep 9, 2013

I've just push branch fix-issue-19.
I'll merge this branch in a few days.

t-mat added a commit that referenced this issue Sep 11, 2013
t-mat added a commit that referenced this issue Sep 11, 2013
Now, long-option look more like gzip/bzip2/xz (getopt_long()).
related to issue #19
@t-mat t-mat self-assigned this Mar 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant