-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom SVGs for Radio & Checkbox components #2013
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
@theme-ui/components
Comments
Actually, thinking about it, it probably has to be |
lachlanjc
added
good first issue
Good for newcomers
help wanted
Extra attention is needed
labels
Nov 24, 2021
any updates on it? |
@sikhaman It's not planed in foreseeable future, sorry. You can copy the Checkbox component into your codebase and change the icons there. |
lachlanjc
changed the title
Custom SVGs for Radio & Checkbox compnents
Custom SVGs for Radio & Checkbox components
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
@theme-ui/components
Is your feature request related to a problem? Please describe.
I don't think Theme UI should be opinionated on which SVGs should be used for the
Radio
&CheckBox
componentsDescribe the solution you'd like
Probably an additional prop called
customIcon
maybe... based on which we could conditionally render the passed SVG icon otherwise we use the default icons?Describe alternatives you've considered
The alternative is obviously to rebuild the component from the ground up, but it's really counterproductive given that Theme UI have the component & API in place
Additional context
Theme UI should make it seamless to build a design system & enforcing a specific icon without giving the option to override it sounds a bit counterintuitive for me
The text was updated successfully, but these errors were encountered: