Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selective updating on catalog parameters #40

Open
syasini opened this issue May 22, 2020 · 1 comment
Open

Selective updating on catalog parameters #40

syasini opened this issue May 22, 2020 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@syasini
Copy link
Owner

syasini commented May 22, 2020

Before running build_dataframe() check to see if parameters already exist in the catalog.

At the moment all parameters are calculated upon instantiation which causes large catalogs to load slowly.

@syasini syasini added the help wanted Extra attention is needed label May 22, 2020
@syasini
Copy link
Owner Author

syasini commented Jul 13, 2020

An idea would be to add a new argument to Catalog to indicate which variable should be calculated on instantiation.

for example

catalog = Catalog(data, calculate_vars = ["R_200c", "c_200c", "v_r", "v_lon", "v_lat"])

would only calculate the given variables in build_dataframe.

This could be implemented by adding a hidden variable self._calculate_vars in Catalog and bunch of statements like

if "R_200c" in self._calculate_vars:

to build_dataframe.

This is perhaps not the best idea so feel free to suggest better ones!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant