Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add null byte to EXPORT_HELPER_ID #105

Merged
merged 2 commits into from May 12, 2023
Merged

refactor: add null byte to EXPORT_HELPER_ID #105

merged 2 commits into from May 12, 2023

Conversation

nielsvanvelzen
Copy link
Contributor

Description

Add null byte to the virtual module id to adhere to the rollup plugin conventions.
https://rollupjs.org/plugin-development/#conventions

Linked Issues

Fixes #104

Additional context

@stackblitz
Copy link

stackblitz bot commented May 11, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sxzz sxzz merged commit d37c30a into unplugin:main May 12, 2023
6 checks passed
@sxzz sxzz changed the title Add null byte to EXPORT_HELPER_ID refactor: add null byte to EXPORT_HELPER_ID May 12, 2023
@sxzz
Copy link
Member

sxzz commented May 12, 2023

Merged! Thank you.

@nielsvanvelzen nielsvanvelzen deleted the patch-1 branch May 12, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EXPORT_HELPER_ID should start with a null byte when using Rollup
2 participants