Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: more consistent exception types #24

Open
sabberworm opened this issue Nov 3, 2024 · 0 comments
Open

Improvement: more consistent exception types #24

sabberworm opened this issue Nov 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@sabberworm
Copy link
Collaborator

Currently, misconfigured hops sometimes throw either a NullPointerException, a HopperException or an IllegalArgumentException (or something else entirely). We should try to unify the exception types we use.

Proposal: only throw HopperExceptions for cases where ConflictResolution.THROW is used. All other problems should throw other types of exceptions. IMHO we should go with IllegalArgumentException when we can statically determine that a hop is misconfigured. Other problems should raise the proper exception that is encountered at runtime.

Discuss!

@sabberworm sabberworm added the enhancement New feature or request label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant