You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, misconfigured hops sometimes throw either a NullPointerException, a HopperException or an IllegalArgumentException (or something else entirely). We should try to unify the exception types we use.
Proposal: only throw HopperExceptions for cases where ConflictResolution.THROW is used. All other problems should throw other types of exceptions. IMHO we should go with IllegalArgumentException when we can statically determine that a hop is misconfigured. Other problems should raise the proper exception that is encountered at runtime.
Discuss!
The text was updated successfully, but these errors were encountered:
Currently, misconfigured hops sometimes throw either a
NullPointerException
, aHopperException
or anIllegalArgumentException
(or something else entirely). We should try to unify the exception types we use.Proposal: only throw
HopperException
s for cases whereConflictResolution.THROW
is used. All other problems should throw other types of exceptions. IMHO we should go withIllegalArgumentException
when we can statically determine that a hop is misconfigured. Other problems should raise the proper exception that is encountered at runtime.Discuss!
The text was updated successfully, but these errors were encountered: