Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Ubuntu 24.04, 23.10, Fedora 39, Debian 12 #152

Open
adam-fowler opened this issue Aug 8, 2024 · 2 comments
Open

Support for Ubuntu 24.04, 23.10, Fedora 39, Debian 12 #152

adam-fowler opened this issue Aug 8, 2024 · 2 comments
Labels
release candidate This issue is a candidate for the next release

Comments

@adam-fowler
Copy link
Contributor

There is a PR for adding this to the install script, but now we have moved most of the install code into the swiftly binary we should add this support to the binary

@adam-fowler adam-fowler added the release candidate This issue is a candidate for the next release label Aug 27, 2024
@vsarunas
Copy link

@adam-fowler / @patrickfreed / @cmcgee1024 , do you need any assistance for having Ubuntu 24.04 support?

Or is there a 2 step process; make the #115 available since work has already been done and then remove once swiftly binary is ready to do those steps? #161 looks to be also be in a similar situation.

@cmcgee1024
Copy link
Member

@vsarunas updates to the pull request is welcome and/or new pull requests are welcome.

There are several places in the code that would need to be changed to add Ubuntu 24.04 support. We're hoping to make it easier to manage this in the future using swift.org API. For now, I would use Ubuntu 22.04 as a guide to add 24.04. Some key areas to update:

  • Add a new static for it to PlatformDefinition to signal support
  • Add a prompt and auto-detection for it in Sources/Linux/LinuxPlatform.swift
  • Put the list of required system packages for it in Sources/Linux/LinuxPlatform.swift (derived from the docker file sources)
  • Use the new static platform definition for the swift.org API handling in Sources/SwiftlyCore/HTTPClient.swift
  • Create a new 24.04 docker compose file in docker/
  • We still have the old installer shell script in install/ that would need to be updated too for completeness
  • Updates to tests to get coverage for the platform in Tests/ and install/tests/

@cmcgee1024 cmcgee1024 removed their assignment Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release candidate This issue is a candidate for the next release
Projects
None yet
Development

No branches or pull requests

3 participants