Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support __NO_SIDE_EFFECTS__ in the minifier #7525

Closed
mischnic opened this issue Jun 13, 2023 · 1 comment · Fixed by #7532
Closed

Support __NO_SIDE_EFFECTS__ in the minifier #7525

mischnic opened this issue Jun 13, 2023 · 1 comment · Fixed by #7532
Assignees
@kdy1
Labels
enhancement
Milestone
v1.3.67

Comments

@mischnic
Copy link
Contributor

mischnic commented Jun 13, 2023 •
edited

Describe the feature

Rollup and esbuild now have support for /*#__NO_SIDE_EFFECTS__*/ comments (which is similar to /*#__PURE__*/ but instead on the function declaration)

rollup/rollup#5024
evanw/esbuild#3149
terser/terser#1130

The swc minifier could also use this information

Babel plugin or link to the feature description

No response

Additional context

No response
@kdy1 kdy1 added this to the Planned milestone Jun 13, 2023
@kdy1 kdy1 self-assigned this Jun 13, 2023
@kdy1 kdy1 mentioned this issue Jun 15, 2023
Merged
kdy1 added a commit that referenced this issue Jun 21, 2023
@kdy1
feat(es/minifier): Support __NO_SIDE_EFFECTS__ (#7532)
3ad07a7 
**Related issue:**

 - Closes #7525.
@kdy1 kdy1 modified the milestones: Planned, v1.3.67 Jun 29, 2023
@swc-bot
Copy link
Collaborator

swc-bot commented Jul 29, 2023

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kdy1 kdy1

Labels
enhancement
Milestone
v1.3.67
Development

Successfully merging a pull request may close this issue.

feat(es/minifier): Support __NO_SIDE_EFFECTS__ kdy1/swc
3 participants
@mischnic @kdy1 @swc-bot