Introduce separate timeout column #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukoson
suggested changes
May 29, 2020
There was a problem hiding this comment.
Does not seem compatible with si-tpc-toolkit on master:
http://teamcity.swarm64.com/viewLog.html?buildId=557598&tab=queuedBuildOverviewTab
|
Maybe it's better not to introduce this new - timeout column. Every time the column will be filled with the same value which doesn't make much sense to me. We know the timeout anyway and if we want we can handle it in the test results DB. |
|
Ok. Leaves the question what to do with in general? IMO, overwriting the runtime in the IGNORE case is not a good practice either. |
|
I'd leave IGNORE case with runtime 0 as it is right now but remove timeout column. I don't know, I'm suggesting, maybe Luis won't like this. |
|
I'd be fine with this. Can you clarify with him?
On 3. Jun 2020, at 17:28, Said Karimov <[email protected]<mailto:[email protected]>> wrote:
I'd leave IGNORE case with runtime 0 as it is right now but remove timeout column. I don't know, I'm suggesting, maybe Luis won't like this.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<#41 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AANKP6BK47X7365PMMPODDLRUZTZLANCNFSM4NN3GABQ>.
…--
Sebastian Dressler, Solution Architect
+49 30 994 0496 72 | [email protected]<mailto:[email protected]>
Swarm64 AS
Parkveien 41 B | 0258 Oslo | Norway
Registered at Brønnøysundregistrene in Norway under Org.-Number 911 662 787
CEO/Geschäftsführer (Daglig Leder): Thomas Richter; Chairman/Vorsitzender (Styrets Leder): Dr. Sverre Munck
Swarm64 AS Zweigstelle Hive
Ullsteinstr. 120 | 12109 Berlin | Germany
Registered at Amtsgericht Charlottenburg - HRB 154382 B
[cid:[email protected]]
|
|
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #40 and makes the output more clear. I am not sure whether we should merge this back to previous versions, but maybe it makes sense to do so.