Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apidom-ls: reimplement the logic around reference validation #3964

Open
char0n opened this issue Mar 22, 2024 · 1 comment
Open

apidom-ls: reimplement the logic around reference validation #3964

char0n opened this issue Mar 22, 2024 · 1 comment
Labels

Comments

@char0n
Copy link
Member

char0n commented Mar 22, 2024

Logic around reference validation could be extremely slow, when individual references are pulled out and dererenced separately.

There are definitions that takes more than 20 seconds to process, which is not viable in editor experience scenarios. When we implement #3038, we can just run one single dereference and collect errors as we do the single traversal. From 20 seconds we'll get to 145ms.

Refs #3735

@char0n
Copy link
Member Author

char0n commented Mar 25, 2024

Temporary perf optimization has been applied in #3965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant