Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not crash on toConsole when kind is not known #196

Closed
wants to merge 2 commits into from

Conversation

5p4k
Copy link

@5p4k 5p4k commented Sep 4, 2023

This fixes #195 and perhaps will prevent crashes in the future, should the node kind not be known.

This PR doesn't even attempt to properly support concepts, just allows the documentation building process to go through.

@florianhumblot
Copy link
Collaborator

I think @svenevs put his comment on the wrong PR

Thank you for taking time to try and contribute back to this project!
I will try and look at what to do about concepts this weekend. I have a completely overloaded week though :S
I may be willing to merge it without tests, will have to consider...

is what he said on #201

@svenevs
Copy link
Owner

svenevs commented Oct 22, 2023

I apologize for being stubborn on not letting this hard-fail be relaxed. That said, I thought I was going to archive this repo by now, but it is still something people want. I did the same thing to interface users (PHP, java, etc), but never had the bandwidth to expand support.

Exhale is and always will be C++ first. I will get concepts in, rather than continuing to sit on this. It will need tests, but I will be less strict on getting all cases covered. I just need to "see it to believe it" before I can merge anything. I am somewhat convinced that this is the only reason this repo actually still works as advertised, but will also admit fully that some of the tests are absolutely absurd.

Point is, I'm sorry for the long delay on this, I'm going to try and push concepts through during the next release.

@svenevs svenevs closed this Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'concept' when listing nodes to console
3 participants