🦋 Changeset detected

Latest commit: e795aff

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

There's ssrHtml to check SSRd HTML, and then there's variant (passed to the test function) which you can use to conditionally check something depending on which test variant (Dom, SSR, hydrate) runs

There's ssrHtml to check SSRd HTML, and then there's variant (passed to the test function) which you can use to conditionally check something depending on which test variant (Dom, SSR, hydrate) runs

Thanks...i actually figured that out just now...i've updated the test and changed one snapshot that was now failing. Maybe double check my test to see if this is actually the correct behaviour 😄

I don't think this is the right fix. The right fix is to fix the remove_input_attr_defaults function. Right now it just removes the attributes but it doesn't set the property, which means the value is just lost, leading to far more bugs than just this specific one. The fix is probably just this:

export function remove_input_attr_defaults(dom) {
	if (hydrating) {
		const value = dom.value;
		// @ts-expect-error
		const checked = dom.checked;
		set_attribute(dom, 'value', null);
		set_attribute(dom, 'checked', null);
		dom.value = value;
		// @ts-expect-error
		dom.checked = checked;
	}
}

Mmm...I was under the impression that after the removal hydration still did his job and the value was actually there. Infact in the test I also check that checked is true and it seems to pass. Am I wrong?

I don't think this is the right fix. The right fix is to fix the remove_input_attr_defaults function. Right now it just removes the attributes but it doesn't set the property, which means the value is just lost, leading to far more bugs than just this specific one. The fix is probably just this:

export function remove_input_attr_defaults(dom) {
	if (hydrating) {
		const value = dom.value;
		// @ts-expect-error
		const checked = dom.checked;
		set_attribute(dom, 'value', null);
		set_attribute(dom, 'checked', null);
		dom.value = value;
		// @ts-expect-error
		dom.checked = checked;
	}
}

Btw regardless I can change the fix to be the one you proposed if you think it's a better fix. I'll update the code later.

It seems that it keeps the checked state, but the value state is definetly deleted. So yeah, we can micro-optimize that and don't do the checked set.

It seems that it keeps the checked state, but the value state is definetly deleted. So yeah, we can micro-optimize that and don't do the checked set.

So just to confirm, I'll fix with your code and remove the last line right?

@dummdidumm made a slight modification because reading dom.value was returning "on" when value was not set in checkboxes. This broke tests but also didn't seem like a good thing to have. It should be all green now