-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
200 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,200 @@ | ||
| # Contributing | ||
|
|
||
| We would <img width="15" alt="Love" src="https://github.com/surrealdb/surrealdb/blob/main/img/love.svg?raw=true"> for you to contribute to SurrealDB and help make it better! We want to ensure contributing to SurrealDB is fun, enjoyable, and educational for anyone and everyone. All contributions are welcome, including features, bug fixes, and documentation changes, as well as updates and tweaks, blog posts, workshops, and everything else. | ||
|
|
||
| ## How to start | ||
|
|
||
| If you are worried or don’t know where to start, check out our next section explaining what kind of help we could use and where can you get involved. You can ask us a question on [GitHub Discussions](https://github.com/surrealdb/surrealdb/discussions), or the [SurrealDB Discord Server](https://surrealdb.com/discord). Alternatively, you can message us on any channel in the [SurrealDB Community](https://surrealdb.com/community)! | ||
|
|
||
| ## Code of conduct | ||
|
|
||
| Please help us keep SurrealDB open and inclusive. Kindly read and follow our [Code of Conduct](/CODE_OF_CONDUCT.md). | ||
|
|
||
| <!-- | ||
| -------------------------------------------------- | ||
| ONLY RELEVANT FOR CLIENT SDK REPOSITORIES | ||
| -------------------------------------------------- | ||
| --> | ||
|
|
||
| ## Coding standards | ||
|
|
||
| We aim to develop according to coding standards in-line with each programming language. We suggest you go through the prerequisite reading section below before proceeding with a contribution! | ||
|
|
||
| <details> | ||
| <summary>Prerequisite Reading</summary> | ||
|
|
||
| ## What is a Database Driver? | ||
|
|
||
| A database driver (also known as a client library), is a module for a programming language that is implemented to provide access to SurrealDB, and enables access to the wide range of functionality the database offers. | ||
|
|
||
| Its focus is primarily on network protocol correctness, performance, access to distinct database features, error handling, and in due course, transaction handling and retriability. | ||
|
|
||
| Drivers are not designed to be a one-size-fits-all, as we cannot make assumptions about how users will use the drivers. JDBC? Async? ORM? DSL? Due to the many different features and functionalities in each language, we are unable to provide all this functionality in a single driver. | ||
|
|
||
| We want users to have very clear expectations about how our software works. It’s very important for us that when users move between languages or compare implementations, the SurrealDB integration is as familiar as possible across all languages. | ||
|
|
||
| ## Driver architecture | ||
|
|
||
| We would recommend following the API of the [Rust driver](https://github.com/surrealdb/surrealdb/tree/main/lib), as the Rust driver is fully utilising our capabilities and is the de-facto reference implementation. In the future, it will also be the underlying implementation as we begin to share a common API (either via foreign function interfaces or WASM), with native language-specific bindings. | ||
|
|
||
| Drivers connect to SurrealDB using either REST, a text-based WebSocket protocol, or a binary-based WebSocket protocol. Each of the protocols aims to support as many of the SurrealDB features as possible, ensuring that similar functionality and similar performance are supported regardless of the protocol being used. | ||
|
|
||
| Beyond baseline protocol support, error handling is also a key feature. This is tied with both custom SurrealQL protocol status codes included in the response itself, or with HTTP status codes in some cases. | ||
|
|
||
| There isn't any specific configuration per driver. We may introduce configuration options in due course, and we will update this guide if we change those configurations. | ||
|
|
||
| <!-- | ||
| -------------------------------------------------- | ||
| END | ||
| -------------------------------------------------- | ||
| --> | ||
| </details> | ||
|
|
||
| ## Introducing new features | ||
|
|
||
| We would <img width="15" alt="Love" src="https://github.com/surrealdb/surrealdb/blob/main/img/love.svg?raw=true"> for you to contribute to SurrealDB, but we would also like to make sure SurrealDB is as great as possible and loyal to its vision and mission statement. For us to find the right balance, please open a question on [GitHub discussions](https://github.com/surrealdb/surrealdb/discussions) with any ideas before creating a [**GitHub Issue**](/issues). This will allow the SurrealDB community to have sufficient discussion about the new feature value and how it fits in the product roadmap and vision, before introducing a new pull request | ||
|
|
||
| This is also important for the SurrealDB lead developers to be able to give technical input and different emphasis regarding the feature design and architecture. Some bigger features might need to go through our [RFC process](https://github.com/surrealdb/rfcs). | ||
|
|
||
| ## Submitting a pull request | ||
|
|
||
| The **branch name** is your first opportunity to give your task context. | ||
| Branch naming convention is as follows | ||
|
|
||
| `TYPE-ISSUE_ID-DESCRIPTION` | ||
|
|
||
| It is recommended to combine the relevant [**GitHub Issue**](/issues) with a short description that describes the task resolved in this branch. If you don't have GitHub issue for your PR, then you may avoid the prefix, but keep in mind that more likely you have to create the issue first. For example: | ||
| ``` | ||
| bugfix-548-ensure-queries-execute-sequentially | ||
| ``` | ||
|
|
||
| Where `TYPE` can be one of the following: | ||
|
|
||
| - **refactor** - code change that neither fixes a bug nor adds a feature | ||
| - **feature** - code changes that add a new feature | ||
| - **bugfix** - code changes that fix a bug | ||
| - **docs** - documentation only changes | ||
| - **ci** - changes related to CI system | ||
|
|
||
| ### Commit your changes | ||
|
|
||
| - Write a descriptive **summary**: The first line of your commit message should be a concise summary of the changes you are making. It should be no more than 50 characters and should describe the change in a way that is easy to understand. | ||
|
|
||
| - Provide more **details** in the body: The body of the commit message should provide more details about the changes you are making. Explain the problem you are solving, the changes you are making, and the reasoning behind those changes. | ||
|
|
||
| - Use the **commit history** in your favour: Small and self-contained commits allow the reviewer to see exactly how you solved the problem. By reading the commit history of the PR, the reviewer can already understand what they'll be reviewing, even before seeing a single line of code. | ||
|
|
||
| ### Create a pull request | ||
|
|
||
| - The **title** of your pull request should be clear and descriptive. It should summarize the changes you are making in a concise manner. | ||
|
|
||
| - Provide a detailed **description** of the changes you are making. Explain the reasoning behind the changes, the problem it solves, and the impact it may have on the codebase. Keep in mind that a reviewer was not working on your task, so you should explain why you wrote the code the way you did. | ||
|
|
||
| - Describe the scene and provide everything that will help to understand the background and a context for the reviewers by adding related GitHub issues to the description, and links to the related PRs, projects or third-party documentation. If there are any potential drawbacks or trade-offs to your changes, be sure to mention them too. | ||
|
|
||
| - Be sure to **request reviews** from the appropriate people. This might include the project maintainers, other contributors, or anyone else who is familiar with the codebase and can provide valuable feedback. You can also join our [Weekly Developer Office Hours](https://github.com/orgs/surrealdb/discussions/2118) to chat with the maintainers who will review your code! | ||
|
|
||
| ### Getting a better review | ||
|
|
||
| - [**Draft pull requests**](https://github.blog/2019-02-14-introducing-draft-pull-requests/) allow you to create a pull request that is still a work in progress and not ready for review. This is useful when you want to share your changes with others but aren't quite ready to merge them or request immediate feedback. | ||
| https://github.blog/2019-02-14-introducing-draft-pull-requests/ | ||
|
|
||
| - Once your pull request has been reviewed, be sure to **respond** to any feedback you receive. This might involve making additional changes to your code, addressing questions or concerns, or simply thanking reviewers for their feedback. | ||
|
|
||
| - By using the [**re-request review** feature](https://github.blog/changelog/2019-02-21-re-request-review-on-a-pull-request/), you can prompt the reviewer to take another look at your changes and provide feedback if necessary. | ||
|
|
||
| - The [**CODEOWNERS** file](https://github.com/surrealdb/surrealdb/blob/main/.github/CODEOWNERS) in GitHub allows you to specify who is responsible for code in a specific part of your repository. You can use this file to automatically assign pull requests to the appropriate people or teams and to ensure that the right people are notified when changes are made to certain files or directories. | ||
|
|
||
| <!-- | ||
| **[OPTIONAL - can be removed]** We use [**scheduled reminders** to Slack](https://docs.github.com/en/organizations/organizing-members-into-teams/managing-scheduled-reminders-for-your-team) for abandoned pull requests to will receive reminders to the team's channel for PRs that are non-draft and have no activity for a couple of days. | ||
| --> | ||
|
|
||
| ### Finalize the change | ||
|
|
||
| - We are actively using **threads** to allow for more detailed and targeted discussions about specific parts of the pull request. A resolved thread means that the conversation has been addressed and the issue has been resolved. Reviewers are responsible for resolving the comment and not the author. The author can simply add a reply comment that the change has been done or decline a request. | ||
|
|
||
| - When your pull request is approved, our team will be sure to **merge it responsibly**. This might involve running additional tests or checks, ensuring that the codebase is still functional. | ||
|
|
||
| ### Summary | ||
|
|
||
| To summarize, fork the project and use the `git clone` command to download the repository to your computer. A standard procedure for working on an issue would be to: | ||
|
|
||
| 1. Clone the repository and download it to your computer. | ||
|
|
||
| 2. Pull all changes from the upstream `main` branch, before creating a new branch - to ensure that your `main` branch is up-to-date with the latest changes. | ||
|
|
||
| 3. Create a new branch from `main` like: `bugfix-548-ensure-queries-execute-sequentially`. | ||
|
|
||
| 4. Make changes to the code, and ensure all code changes are formatted correctly. | ||
|
|
||
| 5. Commit your changes when finished, | ||
|
|
||
| 6. Push changes to GitHub. | ||
|
|
||
| 7. Submit your changes for review, by going to your repository on GitHub and clicking the `Compare & pull request` button. | ||
|
|
||
| 8. Ensure that you have entered a commit message which details the changes, and what the pull request is for. | ||
|
|
||
| 9. Now submit the pull request by clicking the `Create pull request` button. | ||
|
|
||
| 10. Wait for code review and approval. | ||
|
|
||
| ## Scalability and Performance | ||
|
|
||
| SurrealDB is designed to be fast and to scale. It is built to work in both a single-node setup and as a distributed cluster. In distributed mode, SurrealDB builds upon [TiKV](https://tikv.org). Please keep in mind that SurrealDB and the Client SDKs are designed to be run in different environments, with different configurations, and at differing scales. | ||
|
|
||
| When contributing code to the database or the Client SDKs, please take into account the following considerations: | ||
|
|
||
| - SurrealDB startup time | ||
| - Query execution time | ||
| - Query response times | ||
| - Query throughput | ||
| - Requests per second | ||
| - Websocket connections | ||
| - Network usage | ||
| - Memory usage | ||
|
|
||
| ## Security and Privacy | ||
|
|
||
| We take the security of SurrealDB code, software, cloud platform, and client SDKs very seriously. If you believe you have found a security vulnerability in SurrealDB, we encourage you to let us know right away. We will investigate all legitimate reports and do our best to quickly fix the problem. | ||
|
|
||
| Please report any issues or vulnerabilities to [email protected], instead of posting a public issue in GitHub. Please include the SurrealDB version identifier, by running `surreal version` on the command-line, and details on how the vulnerability can be exploited. | ||
|
|
||
| When developing, make sure to follow the best industry standards and practices. | ||
|
|
||
| ## External dependencies | ||
|
|
||
| Please avoid introducing new dependencies to SurrealDB or the Client SDKs without consulting the team. New dependencies can be very helpful but also introduce new security and privacy issues, complexity, and impact total docker image size. Adding a new dependency should have vital value on the product with minimum possible risk. | ||
|
|
||
| ## Other Ways to Help | ||
|
|
||
| Pull requests are great, but there are many other areas where you can help. | ||
|
|
||
| ### Blogging and speaking | ||
|
|
||
| Blogging, speaking about, or creating tutorials about one of SurrealDB's many features. Mention [@surrealdb](https://twitter.com/surrealdb) on Twitter, and email [email protected] so we can give pointers and tips and help you spread the word by promoting your content on the different SurrealDB communication channels. Please add your blog posts and videos of talks to our [showcase](https://github.com/surrealdb/showcase) repo on GitHub. | ||
|
|
||
| ### Presenting at meetups | ||
|
|
||
| Presenting at meetups and conferences about your SurrealDB projects. Your unique challenges and successes in building things with SurrealDB can provide great speaking material. We’d love to review your talk abstract, so get in touch with us at [email protected] if you’d like some help! | ||
|
|
||
| ### Feedback, bugs, and ideas | ||
|
|
||
| Sending feedback is a great way for us to understand your different use cases of SurrealDB better. If you want to share your experience with SurrealDB, or if you want to discuss any ideas, you can start a discussion on [GitHub discussions](https://github.com/surrealdb/surrealdb/discussions), chat with the [SurrealDB team on Discord](https://surrealdb.com/discord), or you can tweet [@tobiemh](https://twitter.com/tobiemh) or [@surrealdb](https://twitter.com/surrealdb) on Twitter. If you have any issues or have found a bug, then feel free to create an issue on [**GitHub Issue**](/issues). | ||
|
|
||
| ### Documentation improvements | ||
|
|
||
| Submitting [documentation](https://surrealdb.com/docs) updates, enhancements, designs, or bug fixes, and fixing any spelling or grammar errors will be very much appreciated. | ||
|
|
||
| ### Joining our community | ||
|
|
||
| Join the growing [SurrealDB Community](https://surrealdb.com/community) around the world, for help, ideas, and discussions regarding SurrealDB. | ||
|
|
||
| - View our official [Blog](https://surrealdb.com/blog) | ||
| - Follow us on [Twitter](https://twitter.com/surrealdb) | ||
| - Connect with us on [LinkedIn](https://www.linkedin.com/company/surrealdb/) | ||
| - Join our [Dev community](https://dev.to/surrealdb) | ||
| - Chat live with us on [Discord](https://discord.gg/surrealdb) | ||
| - Get involved on [Reddit](http://reddit.com/r/surrealdb/) | ||
| - Read our blog posts on [Medium](https://medium.com/surrealdb) | ||
| - Questions tagged #surrealdb on [StackOverflow](https://stackoverflow.com/questions/tagged/surrealdb) |