Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for "Segment has a length of 0s" is incorrect #12

Open
hmcq6 opened this issue Dec 12, 2024 · 1 comment
Open

Check for "Segment has a length of 0s" is incorrect #12

hmcq6 opened this issue Dec 12, 2024 · 1 comment
Assignees
@ninofiliu
Labels
bug Something isn't working

Comments

@hmcq6
Copy link

hmcq6 commented Dec 12, 2024 •
edited
Loading

Description

To Recreate

  1. Upload a video clip
  2. Add a Copy Segment of 1s
  3. Add a Glide Segment at Time = 0 where the Length != 0
  4. Render

To Fix

Change segment.time to segment.length

supermosh.github.io/app/src/Render.tsx

Line 47 in 6190f69

(segment.transform === "glide" && segment.time === 0)

Screenshots

Screenshot 2024-12-12 at 5 41 24 PM

Logs

No response

Browsers

Chrome

OS

Mac
@hmcq6 hmcq6 added the bug Something isn't working label Dec 12, 2024
@hmcq6 hmcq6 changed the title Segment has a length of 0s Check for "Segment has a length of 0s" is incorrect Dec 12, 2024
@ninofiliu
Copy link
Collaborator

Thanks for the detailed bug report, I'll look into it asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ninofiliu ninofiliu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hmcq6 @ninofiliu