-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timestamp subtract with overflow #250
Comments
here is another panic: https://github.com/superfly/corrosion/blob/main/crates/corro-agent/src/agent/util.rs#L999 for (_, changeset, _, _) in changesets.iter() {
if let Some(ts) = changeset.ts() {
let dur = (agent.clock().new_timestamp().get_time() - ts.0).to_duration(); // <--- panic here
histogram!("corro.agent.changes.commit.lag.seconds").record(dur);
}
} backtrace:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
in debug build, run
corrosion exec
on node with faster clock cause other nodes panic.https://github.com/superfly/corrosion/blob/main/crates/corro-agent/src/agent/handlers.rs#L860.
since the
Broadcast
changeset sent from node with faster clock has newer timestamp than the receiver node, so subtract with overflow occurs.the panic backtrace:
The text was updated successfully, but these errors were encountered: