Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable schema in client's parameters #62

Open
legaltextai opened this issue Nov 25, 2023 · 6 comments
Open

Enable schema in client's parameters #62

legaltextai opened this issue Nov 25, 2023 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@legaltextai
Copy link

It creates tables by default in 'vecs' schema. It'd be great if users had flexibility to choose another schema when creating a client.Thanks

@olirice
Copy link
Collaborator

olirice commented Nov 27, 2023

the vecs.Collection level might be more appropriate for users who want to spread collections across multiple schemas.

Are you interested in opening a PR?

@olirice olirice added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 27, 2023
@majamil16
Copy link

would be interested in this feature as well! happy to put in a PR if you are not planning on it @legaltextai

@legaltextai
Copy link
Author

i am probably at great risk to sound too stupid, but what is 'PR'?

@olirice
Copy link
Collaborator

olirice commented Nov 29, 2023

A PR is a pull request. It's a part of the GitHub workflow for contributing to a project. I was asking if you'd like to contribute the change that you're requesting

@majamil16
Copy link

opened a PR here #63 would appreciate a review! :)

@olirice

@legaltextai
Copy link
Author

Thank you so much @majamil16 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants