Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: items in the dash should get loading / error statuses #88

Open
2 tasks
EthanLatimerGB opened this issue Mar 11, 2023 · 0 comments
Open
2 tasks

feat: items in the dash should get loading / error statuses #88

EthanLatimerGB opened this issue Mar 11, 2023 · 0 comments

Comments

@EthanLatimerGB
Copy link
Contributor

EthanLatimerGB commented Mar 11, 2023

Description

Currently, when no data is coming through the telemetry Dash page, you simply get empty statuses that don't convey anything happening behind the scenes.
A better way of presenting this would be to have loading statuses plus if nothing ever loads causing a timeout error, the DashStatusItem component should render an error status.
Something like this is currently in the RefactoringWork branch but this needs to be taken further for error statuses.

Requirements

  • Change the Redux state to accommodate for SOCKET_LOADING and SOCKET_ERROR flags. The SIO should be able to handle error statuses with sio.on("error", ...). For SOCKET_LOADING statuses, we could by default set SOCKET_LOADING state in redux as true. Then once the socket is connected with SIO, we also update that state flag to false.
  • Update the Dash and DashStatusItem components to accommodate for the flags through useSelector. If the flag is set to SOCKET_LOADING, we render with the same styling a component with the message "connecting to service". For the error flag, we render a similar thing but a message like "error connecting to service".

Relevant FSUK Rules

N/A

Additional Notes

@AndreasDemenagas AndreasDemenagas changed the title Items in the Dash should get loading / error statuses feat: items in the dash should get loading / error statuses Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant