You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, when no data is coming through the telemetry Dash page, you simply get empty statuses that don't convey anything happening behind the scenes.
A better way of presenting this would be to have loading statuses plus if nothing ever loads causing a timeout error, the DashStatusItem component should render an error status.
Something like this is currently in the RefactoringWork branch but this needs to be taken further for error statuses.
Requirements
Change the Redux state to accommodate for SOCKET_LOADING and SOCKET_ERROR flags. The SIO should be able to handle error statuses with sio.on("error", ...). For SOCKET_LOADING statuses, we could by default set SOCKET_LOADING state in redux as true. Then once the socket is connected with SIO, we also update that state flag to false.
Update the Dash and DashStatusItem components to accommodate for the flags through useSelector. If the flag is set to SOCKET_LOADING, we render with the same styling a component with the message "connecting to service". For the error flag, we render a similar thing but a message like "error connecting to service".
Relevant FSUK Rules
N/A
Additional Notes
The text was updated successfully, but these errors were encountered:
AndreasDemenagas
changed the title
Items in the Dash should get loading / error statuses
feat: items in the dash should get loading / error statuses
Mar 14, 2023
Description
Currently, when no data is coming through the telemetry Dash page, you simply get empty statuses that don't convey anything happening behind the scenes.
A better way of presenting this would be to have loading statuses plus if nothing ever loads causing a timeout error, the DashStatusItem component should render an error status.
Something like this is currently in the RefactoringWork branch but this needs to be taken further for error statuses.
Requirements
sio.on("error", ...)
. For SOCKET_LOADING statuses, we could by default set SOCKET_LOADING state in redux as true. Then once the socket is connected with SIO, we also update that state flag to false.Relevant FSUK Rules
N/A
Additional Notes
The text was updated successfully, but these errors were encountered: