New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate offense messages in `RuboCop::Cop::Isucon::Mysql2::NPlusOneQuery` #117

Open

sue445 opened this issue Nov 28, 2021 · 0 comments · May be fixed by #102

Labels

bug

Owner

sue445 commented Nov 28, 2021

rubocop-isucon/spec/rubocop/cop/isucon/mysql2/n_plus_one_query_spec.rb

Lines 137 to 139 in c4e9412

    
                       teacher = db.xquery('SELECT * FROM `users` WHERE `id` = ?', course[:teacher_id]).first 
        
                                 ^^ This looks like N+1 query. 
        
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This looks like N+1 query.

sue445 added the bug label

sue445 linked a pull request

that will close this issue

[WIP] Fixed. NPlusOneQuery duplicate offense #102

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment