Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid selfclosing <em/> tag in exported html when enclosing inline nodes #1166

Open
dannelundqvist opened this issue Mar 22, 2018 · 5 comments
Labels

Comments

@dannelundqvist
Copy link
Contributor

When enclosing to inline nodes (a elements) in one annotation (em, strong...) the export produces a self closing element not valid in html.

Steps to reproduce

  1. Create two links
  2. Select the two links
  3. Select an annotation as em

ezgif-3-153a283a1b

The result is invalid html
localhost_5000__

Possibly related to #375

@dannelundqvist
Copy link
Contributor Author

In addition all em tags above share the same id which also is invalid html.

@olaanders
Copy link

And when loading the document with the duplicated "id" attributes in substance, these elements get deleted.

@obuchtala
Copy link
Member

Thanks for reporting. Will work on this.

@obuchtala obuchtala added the bug label May 18, 2018
@obuchtala
Copy link
Member

obuchtala commented May 18, 2018

The empty artifact element is easy to fix.
However @olaanders mention is much worse.
@dotvoid How many freedom is there to store an attribute to link to the master element?

Other alternatives:

  • drop ids at all for such 'unimportant' elements
  • use ids with a ...#<number> suffix

@obuchtala
Copy link
Member

BTW, have you been using an XML exporter (i.e. with an XML DO)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants