New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Size of the Product / Module StripeApplePay has incremented significantly #3548
Comments
Hello, thanks for filing this! It looks like we added some new use of async/await, which caused Xcode to bundle Out of curiosity, would it be possible to set your App Clip's minimum target OS to 14.5 or later? We may want to use async/await in the future, but we don't want to break any existing users. |
@davidme-stripe Thanks for the response and the help. And yeah I almost sure it would be possible to bump up, thanks for the helps and excited for the changes then. As side note, at the moment we are going to use keep using the version 23.27.0 that solves our use cases. |
## Summary This contains async/await code, which was causing StripeApplePay to pull in the Swift Concurrency libraries on iOS 14.0 or earlier. Move it to StripePaymentSheet, as it isn't used by other frameworks. ## Motivation #3548 ## Testing `swift-package-info binary-size --local-path . --product StripeApplePay` ## Changelog Will add
Should be fixed in 23.27.2, let us know if you're still seeing issues with the SDK size! |
Summary
From version 23.27.0 and 23.27.1 the size of the
StripeApplePay
, the size of the binary increases a couples of MB, making the module unusable for App ClipsCode to reproduce
NONE - Only installing the SDK
iOS version
iOS 17.0 and onwards
Installation method
SPM
SDK version
23.27.1
Other information
Tool that I use to measure:
Swift Package Info
https://github.com/marinofelipe/swift-package-info
And the results are:
Version 23.27.0
Version 23.27.1
Note:
Even thou I know that is not an official tool by any sorts, I have used this tool and is consistent with the behavior that I see in the size of the binaries published in Testflight. (Obviously the change is not that drastic, but just 1 more MB can be a detriment to an AppClip).
The text was updated successfully, but these errors were encountered: