Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "This is an error in Swift 6" warnings #3509

Closed
filippopassante opened this issue Apr 11, 2024 · 3 comments
Closed

Fix "This is an error in Swift 6" warnings #3509

filippopassante opened this issue Apr 11, 2024 · 3 comments

Comments

@filippopassante
Copy link

Is Stripe working on fixing "This is an error in Swift 6" type of warnings?

For instance, if you follow the steps at https://docs.stripe.com/payments/quickstart and enable complete strict concurrency checking in Xcode 15.3, you get many warnings in CheckoutViewController, the first being "Reference to class property 'defaultPublishableKey' is not concurrency-safe because it involves shared mutable state; this is an error in Swift 6", caused by the line StripeAPI.defaultPublishableKey = "pk_test_51HNYvGL7qPFrjsUBKZYLMaWPav85CLd1BqZT9aJyCvwY9Ze15N0R1lzYgyehphIiFjCUz4dZcSs1y6XI0Og4aF3s00fekexikN", which I don't think I can solve.

@davidme-stripe
Copy link
Contributor

Thanks for filing this! We do plan to fix these, tracking in: #3324

@filippopassante
Copy link
Author

I'm glad to hear that.

Maybe Stripe support should be informed about this, since they previously told me that they cannot make such guarantees.

I made sure to explain to them that the warnings that I'm getting let it be understood that the SDK won't work at all with Swift 6, to which they replied that I should consider other payment service providers.

In fact, I was implementing Adyen until I received your update.

@davidme-stripe
Copy link
Contributor

davidme-stripe commented May 2, 2024

I'm very sorry about that support experience, thanks for flagging it. We'll look into what went wrong. Our policy is to support every new version of Xcode ahead of GA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants