Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Shipping Dagger code/dependencies #8267

Open
chrisjenx opened this issue Apr 13, 2024 · 0 comments
Open

[BUG] Shipping Dagger code/dependencies #8267

chrisjenx opened this issue Apr 13, 2024 · 0 comments
Labels

Comments

@chrisjenx
Copy link

chrisjenx commented Apr 13, 2024

Summary

You are shipping Dagger dependencies and code in your sdks, as third party library it is poor etiquette to force unnecessary dependencies on your consumers. Dagger is not needed in Stripe and at minimum should stripped via R8 or best case as a library be a good citizen and cut down on dependencies you require.

Code to reproduce

stripepaymentsheet jar

Android version

All

Impacted devices

All

Installation method

Gradle

Dependency Versions

For kotlin: NA
For stripe-android: 20.38.0
For Android Gradle Plugin: NA
For Gradle version: 8.7

SDK classes

com.stripe.android.customersheet.injection.*

Other information

e: Supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath:
class com.stripe.android.customersheet.injection.CustomerSheetViewModelModule_Companion_ContextFactory, unresolved supertypes: dagger.internal.Factory

@chrisjenx chrisjenx added the bug label Apr 13, 2024
@chrisjenx chrisjenx changed the title [BUG] Shipping Dagger dependenices [BUG] Shipping Dagger code/dependencies Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant