Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /v1/terminal/readers missing preview param serial_number #129

Open
naseemkullah opened this issue Aug 30, 2023 · 4 comments
Open

GET /v1/terminal/readers missing preview param serial_number #129

naseemkullah opened this issue Aug 30, 2023 · 4 comments
Assignees
Labels

Comments

@naseemkullah
Copy link

this guy

I noticed this when using stripe-node - not sure how the openapi spec gets updated as it all seems to be done by a bot? Is there a way I could submit a fix?

@remi-stripe remi-stripe self-assigned this Aug 30, 2023
@remi-stripe
Copy link
Collaborator

@naseemkullah thanks for the report. The problem is that feature is still tagged as "preview" on our end and so it's visible in the docs but not. considered fully public. It's definitely a bug though so I'll work on getting this fixed! I'll close this out for now as this will automatically be fixed once the parameter is properly released publicly!

@naseemkullah
Copy link
Author

@naseemkullah thanks for the report. The problem is that feature is still tagged as "preview" on our end and so it's visible in the docs but not. considered fully public. It's definitely a bug though so I'll work on getting this fixed! I'll close this out for now as this will automatically be fixed once the parameter is properly released publicly!

Thanks @remi-stripe - can you keep this open until it's released publicly or that preview features are properly added to types? That will make this easier to track on our end to know when to remove the required type casting. If not is there another issue that could be tracked?

@naseemkullah
Copy link
Author

hi Rémi, not to increase scope of this, but also interested in returned Readers device_deploy_group prop, though that one does not even seem to be in the docs.

@remi-stripe
Copy link
Collaborator

That one is not a public feature so it wouldn't be in our public openapi spec. I'd recommend working with your Stripe contact that gave you access to this feature instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants