Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit "Insert link" Dialog With Enter Key #4412

Open
2mal3 opened this issue Mar 7, 2024 · 0 comments · May be fixed by #4423
Open

Submit "Insert link" Dialog With Enter Key #4412

2mal3 opened this issue Mar 7, 2024 · 0 comments · May be fixed by #4423
Labels
good first issue Type: Feature Request New feature or request Unit: Editor Issues related to the editor

Comments

@2mal3
Copy link

2mal3 commented Mar 7, 2024

What problem are you facing?

In the Desktop Editor, as can be seen in the clip, you must confirm the insertion of a link into existing text by clicking the Insert link button. Confirming with the Enter key does not work. You have to move the mouse, which makes the whole process unnecessarily slow and cumbersome compared to a simple keystroke.

Screencast.webm

What's the solution you'd like to see in Notesnook?

Make it possible to confirm the Insert link dialog with the Enter key in addition to the button when you have selected one of the two text fields.

What alternatives have you considered?

Of course, you can also use the Tab key to jump to the button. However, this requires an additional keystroke and is not as intuitive.

Additional context

Tested Versions

  • 2.6.16-9b72890-web
  • 2.6.14-fbded93-desktop

Doesn't work on mobile either, but isn't really important there.

@thecodrr thecodrr added Unit: Editor Issues related to the editor good first issue and removed Status: Pending labels Mar 8, 2024
@alihamuh alihamuh linked a pull request Mar 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Type: Feature Request New feature or request Unit: Editor Issues related to the editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants