Always set parallelism to 1 #428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeznet
requested changes
Jul 15, 2022
There was a problem hiding this comment.
Actually, we cannot do this way, since the Parallelism in FunctionDetails is been used by https://github.com/apache/pulsar/blob/branch-2.10/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/ContextImpl.java#L302-L305, which will break this feature in function-mesh.
|
closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #368
Motivation
Update the replicas shouldn't recreate pod
Modifications
Set parallelism to const 1
Another way is to add a field to set the parallelism, but I think we don't need that
Verifying this change
Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
no-need-docbug fix