Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Use the new XS IconButton to clear the combobox #1837

Open
lucasboilly opened this issue Jan 3, 2025 · 0 comments
Open

[feat]: Use the new XS IconButton to clear the combobox #1837

lucasboilly opened this issue Jan 3, 2025 · 0 comments
Assignees
Labels
good first issue Good for newcomers issue: enhancement Issue suggesting an enhancement to an existing feature

Comments

@lucasboilly
Copy link

lucasboilly commented Jan 3, 2025

A clear and concise description of what the feature is

Replace the current clear cross icon with the new XS variant of the IconButton.

Why should this feature be included?

  • It increases the click area and makes it more accessible.
  • It adds hover and clicked states directly inherited from IconButton.

Please provide an example for how this would work

It's supposed to look like this. Please make sure that the IconButton is vertically centered because that's currently not the case with the clear cross icon.

CleanShot.2024-11-08.at.11.32.56.mp4
@lucasboilly lucasboilly added the issue: enhancement Issue suggesting an enhancement to an existing feature label Jan 3, 2025
@lucasboilly lucasboilly self-assigned this Jan 3, 2025
@lucasboilly lucasboilly added the good first issue Good for newcomers label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers issue: enhancement Issue suggesting an enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant