Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Checkbox missing padding in RTL #1714

Closed
zaaakher opened this issue May 7, 2024 · 1 comment · Fixed by #1685
Closed

[bug]: Checkbox missing padding in RTL #1714

zaaakher opened this issue May 7, 2024 · 1 comment · Fixed by #1685
Assignees
Labels
issue: bug Issue reporting a bug status: confirmed Confirmed by a Strapi Team member or multiple community members

Comments

@zaaakher
Copy link

zaaakher commented May 7, 2024

What version of strapi-design-system are you using?

[email protected]

[email protected]

@strapi/[email protected]

What's Wrong?

Upon creating this PR in Strapi admin. I realized the checkbox doesn't have a space between the box and the label when the language is RTL.

When LTR

image

When RTL

image

Upon further investigation it seems to be coming from here

To Reproduce

1- Create a <div>

2- Set the property dir to `RTL

3- Place a <Checkbox/> component inside that RTL div.

4- See the lack of space between the label and the box, switch back and forth between rtl and ltr to see the difference.

Expected Behaviour

It should use paddingStart instead of paddingLeft so that it's consistent regardless of direction. I was gonna make a PR for it but handleResponsiveValues.ts looked too complex for me to get through it in the short time I have. So I kindly leave it to you. I appreciate your efforts :)

@zaaakher zaaakher added the issue: bug Issue reporting a bug label May 7, 2024
@joshuaellis joshuaellis added this to the v2.0.0 milestone May 7, 2024
@joshuaellis joshuaellis linked a pull request May 7, 2024 that will close this issue
@joshuaellis joshuaellis added the status: confirmed Confirmed by a Strapi Team member or multiple community members label May 7, 2024
@joshuaellis joshuaellis removed this from the v2.0.0 milestone Jun 13, 2024
@madhurisandbhor
Copy link
Contributor

It should work fine in V2 as its using gap instead of padding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug status: confirmed Confirmed by a Strapi Team member or multiple community members
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants