Error When uid is Invalid (deepPopulate.ts)

[101sam]

Bug Report: Error When uid is Invalid (deepPopulate.ts)

Problem Description

When uid is invalid, the strapi.getModel(uid) call returns undefined, causing an error when attempting to access model.attributes in the following line:

const model = strapi.getModel(uid);
const attributes = Object.entries(model.attributes);

This results in the following error:

[2025-01-02 11:14:44.926] error: Cannot read properties of undefined (reading 'attributes')
TypeError: Cannot read properties of undefined (reading 'attributes')
    at getDeepPopulate (/path/to/your/project/dist/src/middlewares/deepPopulate.js:17:45)
    ...

Steps to Reproduce

1. Enable public access to an API endpoint.
2. Send a GET request to an invalid resource, e.g., GET ~/api/articles/RandomID.
3. Observe the error in the server console.

Expected Behavior

If uid is invalid, the code should handle the case gracefully without throwing an error. Instead, it should return an empty object or an appropriate fallback response.

Proposed Solution

Add a check to validate the model before accessing its attributes. Update the code as follows:

const model = strapi.getModel(uid);

if (!model) {
  return {}; // Return an empty object if the model is undefined
}

const attributes = Object.entries(model.attributes);

Impact

This fix ensures that invalid uid values are handled safely, preventing server errors and improving the robustness of the middleware.

Additional Notes

• This issue occurs in the middleware file deepPopulate.js at line 17.
• Ensure that similar checks are implemented wherever strapi.getModel is used to prevent similar errors.

Screenshots

Additional context

Add any other context about the request here.