* Remove members only option from dropdown #3147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can get the LifterLMS team to add a filter for us, so we don't have to use JS to remove this value (kind of hacky). Do you know where in the LifterLMS code we would want that filter? |
kimcoleman
requested changes
Jan 21, 2025
There was a problem hiding this comment.
This filter was added in LifterLMS release this week. We can redo this PR now to use that filter instead. gocodebox/lifterlms#2831
|
done @kimcoleman |
…nage plan availability dropdown visibility
MaximilianoRicoTabo
force-pushed
the
bugfix/hide-members-only-access-plan
branch
from
3e3a07e to
bb41512
Compare
kimcoleman
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Hook on Access Plan action to add a jQuery snippet that removes the not wanted option in case streamline setting is checked.
Resolves #3088
How to test the changes in this Pull Request:
See related issue for reproduce steps.
Other information:
Changelog entry