Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with edit rules panel and tree view #117

Open
cmart6780 opened this issue Dec 9, 2024 · 3 comments
Open

Issue with edit rules panel and tree view #117

cmart6780 opened this issue Dec 9, 2024 · 3 comments

Comments

@cmart6780
Copy link

cmart6780 commented Dec 9, 2024

loving this! replaced all my bookmark and regex highlighters. 2 issues im encountering, though. I just wanted to say thanks first and tell you i really appreciate your excellent work with this extension.

If i hit the Edit Rules button and adjust something, and then go back to the normal interface, all of the "<" in my lookbehinds are replaced by &lt;. This is kind of 2 issues, actually, because the reason i have to do this is because I cant remember my editor background color, and every time i try to erase the background color in the rule, it keeps resetting. Also, the color picker is always in the way of the textbox. You can get the cursor in there and edit blindly which is not a big deal but the other issue persists.

The second issues is that when i add a tree item, in the tree it shows a green checkmark and next to that is blank. underneath the blank is my new rule. so every tree item is using up 2 rows and makes things a lot harder to look through. Below I have pasted my .json setting for adding the tree items.

"todo-tree.general.tags": [
"//Incomplete:",
"//Critical:",
"//Important:",
"//Future ToDo:",
"//ToDo:"
],"

ill include pics of both:
The one screenshot shows a lot of replaced text where "<" used to be, because i was trying to repeat the issue to see if it was only a specific instance and the problem kept exacerbating. I didnt test every possible factor but it seems that it happens any time the edit rules code is changed in any way.

Screenshot 2024-12-09 115158
Screenshot 2024-12-09 115628
Screenshot 2024-12-09 115556
Screenshot 2024-12-09 120041

@stneveadomi
Copy link
Owner

Thanks for contributing an issue and using grepc! I appreciate the kind words.

I definitely agree with the issues you identified. However, I will make 2 separate issues from your description and let me know if I summarized your issues accurately:

  1. Opening and closing editor mode improperly encodes/decodes the text (e.g. & <-> amp, etc)
  2. Color picker is broken (very aware of this, pesky 3rd party library has been proving difficult to integrate)

Unfortunately, the 2nd issue you mentioned in your post is of a different extension (not grepc) that I do not maintain.
I looked and found their repository for you. You can post on their GitHub repo and hopefully find more information there!

https://github.com/Gruntfuggly/todo-tree

@stneveadomi
Copy link
Owner

Created #119 #118 from this issue.

@cmart6780
Copy link
Author

oh my gosh sorry about that lol. I got the ToDo extension to put the things i tag in your extension on the tree and i was thinking of them as 1 extension! smh

Thank you for pointing that out and I appreciate you looking into these issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants