-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The ClaimSetInterface API is unclear #61
Comments
@steverhoades do you have any insight on this ? Is my analysis of the expected types correct ? And what should be done about that ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The interface ClaimSetInterface defines a
getClaims(): array
method without defining the expected type for the array.This interface is used in 2 places:
ClaimSetEntity
class implements it (alongside a confusingScopeInterface
which is not about representing a scope but a class with agetScope
method) and seems to expectlist<string>
as the type of the array based on the usages in ClaimExtractorIdentityProviderInterface
is expected to return aUserEntityInterface
implementing it. The IdTokenResponse then expectsgetClaims
to returnarray<string, string>
based on the usage in the second argument ofClaimExtractorInterface
I think we should have 2 different interfaces there, one representing the claims available as a user (being a map from claim names to claim values) and another one representing a set of claim names associated with a scope.
The text was updated successfully, but these errors were encountered: