Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color schemes should avoid losing information content #585

Open
hallpell opened this issue May 23, 2020 · 1 comment
Open

Color schemes should avoid losing information content #585

hallpell opened this issue May 23, 2020 · 1 comment

Comments

@hallpell
Copy link
Collaborator

Some color schemes for the code can leave out information, especially the 'matching parenthesis' bit. Monokai, 3024-night, base16-dark, and midnight just have an underline for the matching paren which is much easier to miss.

Also some issues with bolding that other people brought.

It might make sense to either remove some of the less clear color schemes, or see if we can change the styling a bit to emphasize common student issues.

@hallpell
Copy link
Collaborator Author

Based on #615 , this can be dealt with by the css files provided by codemirror. I'm considering having our own copies of them that modify the matching-bracket property to be more obvious/obnoxious for some of the schemes that are currently more subtle. Diverging from the codemirror code base gives me pause, but I think we'll already be going away from it enough that this won't lose anything important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant