Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGRA to BGR only supports one camera, require both left and right to be BGR/RGB #13

Open
2 tasks done
MrOCW opened this issue Dec 7, 2022 · 2 comments
Open
2 tasks done
Assignees
Labels
feature_request New feature or request

Comments

@MrOCW
Copy link

MrOCW commented Dec 7, 2022

Preliminary Checks

  • This issue is not a duplicate. Before opening a new issue, please search existing issues.
  • This issue is not a question, bug report, or anything other than a feature request directly related to this project.

Proposal

the conversion node only converts the left camera, both left and right cameras should be converted to BGR

Use-Case

bgra8 incompatible with isaac ros

Anything else?

Currently not using composition to achieve this but it'll be nice to have 2 image subscribers in the component

@Myzhar Myzhar added the feature_request New feature or request label Dec 7, 2022
@Myzhar Myzhar self-assigned this Dec 7, 2022
@Myzhar
Copy link
Member

Myzhar commented Dec 7, 2022

@MrOCW this is indeed an example, you can modify and adapt it to subscribe to both left and right topics and convert them all.

We can consider improving the example, but it's not a high-priority task.

@MrOCW
Copy link
Author

MrOCW commented Dec 7, 2022

@Myzhar I have tried creating separate subs and pubs for left and right but I am stuck on how to remap the camera_info topic required by image_transport's create_camera_subscriber as both left and right topics end up having the same /zed2i/camera_info topic string. Do you have any advice for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature_request New feature or request
Development

No branches or pull requests

2 participants