Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests fail on Windows #431

Open
olivierperez opened this issue Jul 18, 2021 · 0 comments
Open

Unit Tests fail on Windows #431

olivierperez opened this issue Jul 18, 2021 · 0 comments

Comments

@olivierperez
Copy link

Hello, I was going to try to contribute but the Unit Tests fail because of line separator.

Unix line separator is \n
Window line separator is \r\n

For instance CyclicDependencyException uses System.getProperty("line.separator") or %n to generate error messages, but CyclicDependencyExceptionTest check result with \n.

If you're OK, I can do the fix myself and open a PR.

I think I may fix it by using \n everywhere because Windows understand it perfectly. So the code won't be platform-dependent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant