You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I was going to try to contribute but the Unit Tests fail because of line separator.
Unix line separator is \n Window line separator is \r\n
For instance CyclicDependencyException uses System.getProperty("line.separator") or %n to generate error messages, but CyclicDependencyExceptionTest check result with \n.
If you're OK, I can do the fix myself and open a PR.
I think I may fix it by using \n everywhere because Windows understand it perfectly. So the code won't be platform-dependent.
The text was updated successfully, but these errors were encountered:
Hello, I was going to try to contribute but the Unit Tests fail because of line separator.
Unix line separator is
\n
Window line separator is
\r\n
For instance
CyclicDependencyException
usesSystem.getProperty("line.separator")
or%n
to generate error messages, butCyclicDependencyExceptionTest
check result with\n
.If you're OK, I can do the fix myself and open a PR.
I think I may fix it by using
\n
everywhere because Windows understand it perfectly. So the code won't be platform-dependent.The text was updated successfully, but these errors were encountered: