-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use root account in loadgen #4445
Comments
we need multiple accounts because of the way transaction queues work, so I am not sure which part of loadgen would get simplified? |
Ah, I see.
I agree for most load gen operations we will want simultaneous transaction processing (and therefore need source accounts for each transaction), but if we want to have a linear sequence of transactions processed then we can re-use the same account, and the account could be the root account. For example, this issue was motivated by needing to create accounts in order to do soroban network upgrades with loadgen. That being said, I'm not sure of other scenarios where root account access would be useful. cc @marta-lokhova |
the issue should track soroban upgrade loadgen modes only, where we don't need multiple accounts and can simply use the root account. right now this limitation creates unnecessary burden in the codebase/CI where we need to create accounts first before executing soroban upgrades. |
Currently,
LoadGenerator
operations require an initial account creation step and theGeneratedLoadConfig
for the operations require specification of offsets to utilize the created accounts as source accounts.When
LoadGenerator
isstart
-ed, themRoot
account is initialized. Currently, the root account is only used to create other accounts. We should make it possible to utilize themRoot
account for loadgen operations. This would simplify loadgen usage by removing the extra account creation step and prevent footguns associated with specifying the correct offset in subsequent operations. In certain scenarios, this granular control is necessary, but for some operations, such as executing soroban network upgrades with loadgen, the exact account being used is irrelevant.The text was updated successfully, but these errors were encountered: