Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subdivisions with data from Wikidata #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vinceh121
Copy link

@vinceh121 vinceh121 commented Jul 9, 2024

Closes #85

Updates the subdivisions.json file to include subdivisions that were missing.
Data is from Wikidata and under the CC0 license.

Script used to fetch is available here: https://gist.github.com/vinceh121/ae44bcb6cde8b2ffe0948e3485cb6023

To update the other subdivisions files, do you already have scripts in place to update them from the JSON one? If not I can write a quick one.

@stefangabos
Copy link
Owner

this works fine and does what it says it's just that the data is not entirely correct for real-life usage.
i am already working on a script for updating this but it is a lot more complicated than it might appear at first.

for example, in romanian we don't say "Harghita County" - it's just "Harghita" - and that's what I would want to offer in a dropdown for users. then there are countries where there are departments and jurisdictions and/or counties but in real life usage users would only have to select from counties and never from departments. then there are local variants for subdivisions (i.e. names for the same subdivision in various local languages).

so, it is important to highlight the type of subdivision (which can be used by people in the know to show what it's common for them) and the name in english and in the native language plus any local variants - take for example China

i am working on this every now and then and will have this ready at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subdivision depth
2 participants