-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugs and fixes #1521
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello
I really love Steal.js, but I found some bugs in Steal-tools and Steal-react-jsx and fixed them 馃敤 馃槂
I will be happy if these fixes are applied 馃槂
so far I have to change them manually when creating a new project 馃槩
I'm sorry if something is misspelled, English is not my primary language.
Steal-tools problems:
1. Blacklist option Error
I got this error message when i start steal-tools build in npm scripts:
and i don't have in package.json blacklist option
Fix:
So i look for Babel options and i add this line:
in to this file : node_modules\steal-tools\lib\graph\treeshake.js
2. Path problem
I got this error in Steal-tools build, but it's look like, this error is only in jsx files:
but in developer mode without steal-tools works fine, i got this error only when i start build
This is path in jsx file:
This is error message:
The original path is : D:\Work\Webs\Steal\App\App\Core\components\style.css
This is my project directory where are node modules and package.json : D:\Work\Webs\Steal\App
But this is problem only in jsx files, in js files works "./"path fine.
Fix:
For fix this problem i add some lines into steal-react-jsx plugin:
Full fixed Steal-react-jsx plugin is down below
Steal-react-jsx problems:
1. All in one line
I found a problem in leading and trailing spaces replace code, which remove all spaces in jsx files
and then all code is in one line
In the picture you can see console.log of source (jsx file) and the error message
Original code has gm modifiers in replace and the m = (multi line) is for all lines in string, it need to be removed
Fixed code:
2. React.Fragment short code support
Steal using old version of babel so shorted version of <React.Fragment> = <> is not supported
Fix:
In the Steal-react-jsx plugin i add support for React.Fragment by replacing the empty tags "<> </>"
And now it's works fine 馃槃
My edited Steal-react-jsx plugin:
Another not fixed problem
In Steal-css "@import" not works in Steal-Tools build, all css imports missing, but in dev mode works fine
@import (url)
Versions and package.json:
The text was updated successfully, but these errors were encountered: