Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet: update use of GetWalletToken endpoint to GetWalletTokenBalances #20473

Open
J-Son89 opened this issue Jun 14, 2024 · 5 comments · May be fixed by #21625
Open

Wallet: update use of GetWalletToken endpoint to GetWalletTokenBalances #20473

J-Son89 opened this issue Jun 14, 2024 · 5 comments · May be fixed by #21625
Assignees
@vkjr
Labels
feature feature requests wallet-core Issues for mobile wallet team
Milestone
2.32.0

Comments

@J-Son89
Copy link
Contributor

J-Son89 commented Jun 14, 2024

For 2.31 release:
Following from the work on Status-Go
status-im/status-go#5320

Mobile wallet needs to migrate to the new status go endpoint GetWalletTokenBalances
@J-Son89 J-Son89 added the feature feature requests label Jun 14, 2024
@J-Son89 J-Son89 added the wallet-core Issues for mobile wallet team label Jun 14, 2024
@J-Son89
Copy link
Contributor Author

J-Son89 commented Jun 14, 2024

cc @alaibe

@J-Son89 J-Son89 moved this to Next iteration in Status Desktop/Mobile Board Jun 18, 2024
@shivekkhurana shivekkhurana added this to the 2.31.0 Beta milestone Oct 3, 2024
@churik
Copy link
Member

churik commented Oct 7, 2024 •
edited
Loading

@shivekkhurana why this issue is added to 2.31, maybe I missed something or it was added by mistake? afaik we need to cut the branch in several days, so it won't be possible to complete that.

@churik churik added the re-check label Oct 9, 2024
@churik
Copy link
Member

churik commented Oct 9, 2024

Postponed due to time constraints to the next release, also we'll recheck it as the issue is fairy old

cc @shivekkhurana

@churik churik modified the milestones: 2.31.0 Beta, 2.32.0 Beta Oct 9, 2024
@pavloburykh
Copy link
Contributor

Re-checked. According to request logs we are still using GetWalletToken. So the issue is still valid. requests.log

@briansztamfater briansztamfater mentioned this issue Oct 28, 2024
Open
@vkjr vkjr self-assigned this Oct 29, 2024
@vkjr
Copy link
Contributor

vkjr commented Oct 31, 2024 •
edited
Loading

Related status-go PRs:
Get rid of wallet.Reader.GetWalletToken method
chore(wallet)_: split getWalletTokenBalances into multiple functions

@vkjr vkjr moved this to In Progress in Status Desktop/Mobile Board Oct 31, 2024
@vkjr vkjr linked a pull request Nov 14, 2024 that will close this issue
Open
@vkjr vkjr moved this from In Progress to Code Review in Status Desktop/Mobile Board Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vkjr vkjr

Labels
feature feature requests wallet-core Issues for mobile wallet team
Projects
Status Desktop/Mobile Board
Status: Code Review
Milestone
2.32.0
Development

Successfully merging a pull request may close this issue.

Replace GetWalletToken endpoint with FetchOrGetCachedWalletBalances status-im/status-mobile
5 participants
@shivekkhurana @churik @vkjr @J-Son89 @pavloburykh