You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
then I see that you're calling wallet_stopSuggestedRoutesAsyncCalculation and wallet_getSuggestedRoutesAsync on each digit change, can we do that a bit better? We should think better when we need to call those endpoints.
For example, when user changes "selected account" or "from token" or "to token", it's ok to do those calls, but if user is updating the amount, like you were doing in that video, we should not call those endpoints on every digit change, but do it better and notice when the update is done.
Like, if the amount input field loses focus or there is not amount value update longer than 1000ms (maybe 500ms, maybe 1200ms, up to us to define) then we can consider that user has finished updating the amount and do the calls then. That will save our rpc calls for sure and improve app performances.
From app perspective: in MM for example they don't allow to change the amount "on fly" and you're getting new quotes every 30 sec.
We should also think how it is acceptable for us, may be following this approach is the sensible.
Acceptance Criteria
Make a desicion how to optimize it
PR for improving re-calculation
The text was updated successfully, but these errors were encountered:
Problem
Followup on #21409 (comment)
Implementation
From app perspective: in MM for example they don't allow to change the amount "on fly" and you're getting new quotes every 30 sec.
We should also think how it is acceptable for us, may be following this approach is the sensible.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: