Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Transaction settings for send flow: Nonce and Gas price #21016

Open
1 task done
vkjr opened this issue Aug 12, 2024 · 5 comments
Open
1 task done

[EPIC] Transaction settings for send flow: Nonce and Gas price #21016

vkjr opened this issue Aug 12, 2024 · 5 comments
Assignees
Labels
blocked wallet: TX settings Send screen transaction settings (nonce, limits) wallet-core Issues for mobile wallet team
Milestone

Comments

@vkjr
Copy link
Contributor

vkjr commented Aug 12, 2024

User story

As a wallet user,
I want to edit the parameters of my transaction, like gas, nonce, etc
So I can control how my txn is broadcasted to the network

Description

Currently, the txn is sent with default computed parameters. This is not ideal as the user might want to speed up or cancel txns, by changing nonce and gas price.

This epic implements advanced txn settings for send flow. The same might apply to swaps and smart contract interactions, but for this version, we only build for send flow.

Figma Link: https://www.figma.com/design/xLs1KYmF4e6WwRTZVJKeUK/Wallet?node-id=17669-40876
Schedule for 2.32 https://www.notion.so/Status-Apps-Planning-Releases-11e8f96fb65c801289c5e37099c4039b

Tech debt

Notes

@vkjr vkjr added this to the 2.31.0 Beta milestone Aug 12, 2024
@vkjr vkjr added the wallet: TX settings Send screen transaction settings (nonce, limits) label Aug 12, 2024
@vkjr
Copy link
Contributor Author

vkjr commented Aug 12, 2024

@shivekkhurana, @smohamedjavid, fyi.
I've created a basic set of issues to implement transaction settings discussed in the meeting. Every issue contains the bare minimum and should be refined later.

@churik churik added the wallet-core Issues for mobile wallet team label Aug 28, 2024
@churik churik modified the milestones: 2.31.0 Beta, 2.32.0 Beta Sep 23, 2024
@shivekkhurana shivekkhurana self-assigned this Oct 3, 2024
@vkjr vkjr added the blocked label Oct 17, 2024
@vkjr
Copy link
Contributor Author

vkjr commented Oct 17, 2024

Blocked until designs are finished by @xAlisher
Figma drafts (not for development)

@shivekkhurana shivekkhurana changed the title [EPIC] Transaction settings (nonce and limits) [EPIC] Transaction settings (nonce and limits) [Designs Outdated 🔴] Oct 21, 2024
@shivekkhurana shivekkhurana changed the title [EPIC] Transaction settings (nonce and limits) [Designs Outdated 🔴] [EPIC] Transaction settings : Nonce and Gas price Nov 4, 2024
@shivekkhurana shivekkhurana changed the title [EPIC] Transaction settings : Nonce and Gas price [EPIC] Transaction settings for send flow : Nonce and Gas price Nov 4, 2024
@shivekkhurana shivekkhurana changed the title [EPIC] Transaction settings for send flow : Nonce and Gas price [EPIC] Transaction settings for send flow: Nonce and Gas price Nov 4, 2024
@shivekkhurana
Copy link
Contributor

@vkjr @alwx We have this scheduled for 2.32. Although the designs are not final, the UX has been agreed upon.

We can start working on this. If there are UI changes requested, we can add it later.

@alwx
Copy link
Contributor

alwx commented Nov 5, 2024

@shivekkhurana I've started working on this: #21551

@churik
Copy link
Member

churik commented Nov 25, 2024

I do not think that it is feasible to include this feature to 2.32, postponing due to limited capacity in order to keep release scope clear

cc @shivekkhurana

@churik churik modified the milestones: 2.32.0, 2.33.0 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked wallet: TX settings Send screen transaction settings (nonce, limits) wallet-core Issues for mobile wallet team
Projects
Status: No status
Development

No branches or pull requests

4 participants