Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom GasFeeMode to RouteInputParams #6109

Open
friofry opened this issue Nov 19, 2024 · 1 comment · May be fixed by #6124
Open

Add custom GasFeeMode to RouteInputParams #6109

friofry opened this issue Nov 19, 2024 · 1 comment · May be fixed by #6124
Assignees
@saledjenic
Labels
wallet-team
Milestone
2.32.0

Comments

@friofry
Copy link
Contributor

friofry commented Nov 19, 2024

It should be possible to pass additional parameters to GetSuggestedRoutes when the user selects "Custom" gas fees:

  • Gas amount
  • Gas tip
  • Gas limit
  • Nonce

Status-go sub-task for status-im/status-mobile#21551

Related to:
status-im/status-mobile#21020
https://www.figma.com/design/xLs1KYmF4e6WwRTZVJKeUK/Wallet?node-id=17669-40876&node-type=canvas&t=OEWSlyHMx2PMUrW1-0
@friofry friofry self-assigned this Nov 19, 2024
@friofry friofry mentioned this issue Nov 19, 2024
Open
4 tasks
@friofry friofry added this to the 2.32.0 milestone Nov 19, 2024
@friofry friofry assigned saledjenic and unassigned friofry Nov 19, 2024
@friofry
Copy link
Contributor Author

friofry commented Nov 19, 2024

After discussion with @saledjenic, reassigned to him since he knows this part best and is already working on it.

@saledjenic saledjenic moved this to In Progress in Status Desktop/Mobile Board Nov 22, 2024
@saledjenic saledjenic linked a pull request Nov 26, 2024 that will close this issue
Open
@saledjenic saledjenic moved this from In Progress to Code Review in Status Desktop/Mobile Board Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saledjenic saledjenic

Labels
wallet-team
Projects
Status Desktop/Mobile Board
Status: Code Review
Milestone
2.32.0
Development

Successfully merging a pull request may close this issue.

feat(wallet)!: allowing client to set custom values for fees, nonce, gas status-im/status-go
2 participants
@friofry @saledjenic