Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile settings -> Identity : Addition of validation to bio field #13623

Closed
benjthayer opened this issue Feb 19, 2024 · 2 comments · Fixed by #14772
Closed

Profile settings -> Identity : Addition of validation to bio field #13623

benjthayer opened this issue Feb 19, 2024 · 2 comments · Fixed by #14772
Assignees
@Seitseman
Labels
feature ui-team
Milestone
2.29.0 Beta

Comments

@benjthayer
Copy link

Currently, the Bio field in Profile Settings does not have any validation meaning the user can add any character / emoji they desire.

It was recently confirmed that this field should allow only ASCII characters, not UTF-8 and should support emojis.

@alexjba had a couple of questions in regards to this so creating an issue for us to discuss / track decisions

Screenshot 2024-02-19 at 11 48 08 AM

Figma
https://www.figma.com/file/ibJOTPlNtIxESwS96vJb06/%F0%9F%91%A4-Profile-%7C-Desktop?type=design&node-id=2460-27368&mode=design&t=zk0Rc4XSIlXFhE07-4
@iurimatias iurimatias added this to the 2.28.0 Beta milestone Feb 19, 2024
@iurimatias
Copy link
Member

moving to next milestone due to lack of space in this one

@iurimatias iurimatias modified the milestones: 2.28.0 Beta, 2.29.0 Beta Feb 28, 2024
@noeliaSD
Copy link
Contributor

noeliaSD commented May 3, 2024

A good exercise could be also adding the Identity Tab into storybook if it's not there yet!

Seitseman added a commit that referenced this issue May 15, 2024
@Seitseman
fix(ProfileDescriptionPanel): Profile settings -> Identity : Addition…
f58aab6 
… of validation to bio field

- Added validator to the bio component to allow only ascii and emoji characters
This PR fixes #13623
@Seitseman Seitseman mentioned this issue May 15, 2024
Merged
1 task
@Seitseman Seitseman linked a pull request May 15, 2024 that will close this issue
fix(ProfileDescriptionPanel): Profile settings -> Identity : Addition of validation to bio field #14772
Merged
1 task
Seitseman added a commit that referenced this issue May 15, 2024
@Seitseman
fix(ProfileDescriptionPanel): Profile settings -> Identity : Addition…
1459cfa 
… of validation to bio field

- Added validator to the bio component to allow only ascii and emoji characters
This PR fixes #13623
Seitseman added a commit that referenced this issue May 17, 2024
@Seitseman
fix(ProfileDescriptionPanel): Profile settings -> Identity : Addition…
9144a4d 
… of validation to bio field

- Added validator to the bio component to allow only ascii and emoji characters
This PR fixes #13623
Seitseman added a commit that referenced this issue May 17, 2024
@Seitseman
fix(ProfileDescriptionPanel): Profile settings -> Identity : Addition…
6e62b89 
… of validation to bio field

- Added validator to the bio component to allow only ascii and emoji characters
This PR fixes #13623
Seitseman added a commit that referenced this issue May 17, 2024
@Seitseman
fix(ProfileDescriptionPanel): Profile settings -> Identity : Addition…
b641cd3 
… of validation to bio field

- Added validator to the bio component to allow only ascii and emoji characters
This PR fixes #13623
Seitseman added a commit that referenced this issue May 20, 2024
@Seitseman
fix(ProfileDescriptionPanel): Profile settings -> Identity : Addition…
217244c 
… of validation to bio field

- Added validator to the bio component to allow only ascii and emoji characters
This PR fixes #13623
Seitseman added a commit that referenced this issue May 20, 2024
@Seitseman
fix(ProfileDescriptionPanel): Profile settings -> Identity : Addition…
ed11302 
… of validation to bio field

- Added validator to the bio component to allow only ascii and emoji characters
This PR fixes #13623
Seitseman added a commit that referenced this issue May 20, 2024
@Seitseman
fix(ProfileDescriptionPanel): Profile settings -> Identity : Addition…
e795d5f 
… of validation to bio field

- Added validator to the bio component to allow only ascii and emoji characters
This PR fixes #13623
Seitseman added a commit that referenced this issue May 20, 2024
@Seitseman
fix(ProfileDescriptionPanel): Profile settings -> Identity : Addition…
55edd94 
… of validation to bio field (#14772)

- Added validator to the bio component to allow only ascii and emoji characters
This PR fixes #13623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Seitseman Seitseman

Labels
feature ui-team
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.29.0 Beta
5 participants
@iurimatias @Seitseman @jrainville @noeliaSD @benjthayer