Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text/xml to ContextType of oEmbed response #961

Open
Ovis opened this issue Aug 15, 2021 · 0 comments
Open

Add text/xml to ContextType of oEmbed response #961

Ovis opened this issue Aug 15, 2021 · 0 comments
Labels
General Enhancement New feature or request

Comments

@Ovis
Copy link

Ovis commented Aug 15, 2021

Hi.
I'm trying to create a ShortCode that can use oEmbed in a generic way.
Internally, it is assumed to use GetEmbedResultAsync.

During creation, an error occurred when retrieving information from Flickr.
e.g)
Unknown content type for oEmbed response

I checked and found that Flickr's oEmbedAPI specifies text/xml as ContextType.

else if (response.Content.Headers.ContentType.MediaType == MediaTypes.Xml)

GetEmbedResultAsync seems to have an error because it assumes Application/Xml.

Could you please fix this branch to allow text/xml?

e.g.)
https://www.flickr.com/services/oembed/?url=https://www.flickr.com/photos/yuta_arai_0206/8008087593/

@daveaglick daveaglick added the General Enhancement New feature or request label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Enhancement New feature or request
Development

No branches or pull requests

2 participants