Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of grid-area values #337

Open
BriceG-D opened this issue Jul 26, 2017 · 4 comments
Open

Rewrite of grid-area values #337

BriceG-D opened this issue Jul 26, 2017 · 4 comments

Comments

@BriceG-D
Copy link

Using this sample code
https://developer.mozilla.org/en-US/docs/Web/CSS/grid-template-areas#Example

Actual behaviour

Axis does rename the grid-area: nav; to navigation which does break everything.

#page > nav {
  grid-area: nav;
  background-color: #ffa08c;
}

Expected behaviour

It should not touch the name of the grid-area

@jescalan
Copy link
Member

Hey there! So this is actually an issue with the way that stylus works -- any keyword that isn't in quotes will attempt to render a function, even if called without parens. So what it's trying to do is use this function alias.

I'm not sure how to resolve this without making a large breaking change. Honestly I might just fork it and remove that line referenced above, that should solve it. Axis is also in the process of being moved to a postcss plugin since stylus is kind of on it's way to death.

@j-walker23
Copy link

@jescalan Hey, just curious. Why did you say stylus is on it's way to death? I am just about to start a project with it and i noticed your comment while looking at this repo.
Do you think/know if this is still true? If so you might have saved me, thanks.

@jescalan
Copy link
Member

Hi @j-walker23 -- yeah, I'd recommend postcss for sure. if that's too far, go with sass, although sass will eventually be replaced by postcss as well imo.

@j-walker23
Copy link

@jescalan That's to bad, I just got done going over the full stylus feature set. I have been using sass for 3 or 4 years and stylus seems to have so much more.
Thanks for your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants