Update trino__get_columns_in_relation to use information_schema.columns #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posulliv
force-pushed
the
speed-up-get-columns
branch
from
bb98a04 to
3d38b39
Compare
posulliv
force-pushed
the
speed-up-get-columns
branch
from
3d38b39 to
ed80b2d
Compare
mdesmet
reviewed
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We have noticed that queries against information_schema.columns are consistently faster than describe queries. Especially when using the glue catalog with an iceberg connector. For iceberg in particular, there has been particular optimizations made to speed up queries to information_schema.columns (this PR - trinodb/trino#18315).
We've also seen this is faster for JDBC catalogs.
This PR is to query information_schema.columns for getting column information for a relation.
Resolves #443
Checklist
README.mdupdated and added information about my changechangie newto create a changelog entry