Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] Support HPA maxReplicas #608

Open
BlythMeister opened this issue Aug 4, 2023 · 2 comments
Open

[FEATURE_REQUEST] Support HPA maxReplicas #608

BlythMeister opened this issue Aug 4, 2023 · 2 comments
Labels

Comments

@BlythMeister
Copy link

Description of the problem/feature request
Add check for HPA maxReplicas which functions in the same way as minReplicas

Additional context
We are migrating from datree and this was a check they have: https://hub.datree.io/built-in-rules/ensure-hpa-maximum-replicas

@janisz janisz added good first issue Good for newcomers new-check labels Aug 7, 2023
@janisz
Copy link
Collaborator

janisz commented Aug 7, 2023

As @BlythMeister pointed we already have

templateKey = "hpa-minimum-replicas"
template but it's limited to check minimum. Maybe we should add a new template that will check if replicas is in range and reuse it in min replicas to keep backward compatibility.

@BlythMeister
Copy link
Author

As a use case, maximum is useful in a larger org to ensure someone doesn't go crazy on HPA and set like max 50 (don't ask me why...please don't ask me why!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants